Fix CA2022 warnings: avoid inexact Stream.Read calls#2009
Open
tyrielv wants to merge 1 commit into
Open
Conversation
Replace Stream.Read with Stream.ReadExactly where the caller expects all requested bytes (GitRepo, EnlistmentHydrationSummary, ReusableMemoryStream). Suppress CA2022 in GitIndexParser.ReadNextPage where partial last-page reads are intentional. Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
Stream.ReadwithStream.ReadExactlywhere the caller expects all requested bytes (GitRepo,EnlistmentHydrationSummary,ReusableMemoryStream). Suppress CA2022 inGitIndexParser.ReadNextPagewhere partial last-page reads are intentional.Changes (4 files):
GitRepo.cs— header read must be exact 5 bytesEnlistmentHydrationSummary.cs— index entry count is exact 4 bytesReusableMemoryStream.cs— mock helper reads exact lengthGitIndexProjection.GitIndexParser.cs— pragma suppression; last page of paged index read is intentionally partialValidation: 0 warnings, 0 errors. 807/807 unit tests pass.